New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call g_value_unset() on zeroed GValues #272

Merged
merged 1 commit into from Dec 6, 2017

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Dec 6, 2017

Before GLib 2.48 this caused critical warnings, see
https://bugzilla.gnome.org/show_bug.cgi?id=755766

This should for real fix the warnings on travis.

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Dec 6, 2017

👍

@sdroege

This comment has been minimized.

Member

sdroege commented Dec 6, 2017

Travis confirms 🎆

@sdroege

This comment has been minimized.

Member

sdroege commented Dec 6, 2017

travis and appveyor are happy with the results

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Dec 6, 2017

Then I am as well. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 8ed42df into gtk-rs:master Dec 6, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EPashkin

This comment has been minimized.

Member

EPashkin commented Dec 6, 2017

@sdroege Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment