Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Char tests on platforms where c_char is u8 instead of i8 #285

Merged
merged 1 commit into from Jan 21, 2018

Conversation

Projects
None yet
4 participants
@sdroege
Copy link
Member

sdroege commented Jan 21, 2018

Also add correct casts to the UChar tests while we're at it.

Fixes #284

Fix Char tests on platforms where c_char is u8 instead of i8
Also add correct casts to the UChar tests while we're at it.

Fixes #284
@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 21, 2018

@sdroege Thanks

@ignatenkobrain

This comment has been minimized.

Copy link
Contributor

ignatenkobrain commented Jan 21, 2018

Let me try this on our altarches

@ignatenkobrain

This comment has been minimized.

Copy link
Contributor

ignatenkobrain commented Jan 21, 2018

This works just fine ;)

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Jan 21, 2018

What architecture is that btw? PPC?

@ignatenkobrain

This comment has been minimized.

Copy link
Contributor

ignatenkobrain commented Jan 21, 2018

ppc64, ppc64le, s390x, aarch64, armv7hl

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Jan 21, 2018

I didn't know armv7hl and aarch64 also had unsigned chars by default

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 21, 2018

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 98f3afe into gtk-rs:master Jan 21, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.