New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GIOCondition #290

Merged
merged 1 commit into from Feb 7, 2018

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Feb 7, 2018

No description provided.

@sdroege

This comment has been minimized.

Member

sdroege commented Feb 7, 2018

@EPashkin @tmiasko GIR broke :) It includes the wrong imports when regenerating for glib. Must be use value::XXX.

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 7, 2018

@sdroege I merged fix. Bug was added in gtk-rs/gir@6472453 😉

@sdroege

This comment has been minimized.

Member

sdroege commented Feb 7, 2018

And updated, should be fine now :) Thanks!

// unsafe { TODO: call ffi::g_io_add_watch_full() }
//}
//pub fn io_create_watch(channel: /*Ignored*/&IOChannel, condition: /*Ignored*/IOCondition) -> Option<Source> {
//pub fn io_create_watch(channel: /*Ignored*/&IOChannel, condition: IOCondition) -> Option<Source> {

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Feb 7, 2018

Member

Still not ready for IOChannel?

This comment has been minimized.

@sdroege

sdroege Feb 7, 2018

Member

Maybe, but even if we were this would have to be manual so that the callback, etc can be set on the Source. See glib/src/source.rs for some other examples.

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 7, 2018

Seems all good for me!

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 7, 2018

@sdroege Please, update gir submodule too

@sdroege

This comment has been minimized.

Member

sdroege commented Feb 7, 2018

@sdroege Please, update gir submodule too

Done :)

@sdroege

This comment has been minimized.

Member

sdroege commented Feb 7, 2018

@GuillaumeGomez Should be good to go then :)

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 7, 2018

We generally update git submodules in a commit on its own. Please try to do it like this next time. 😉

Otherwise thanks!

@GuillaumeGomez GuillaumeGomez merged commit 1dcb8f2 into gtk-rs:master Feb 7, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment