New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boxed, shared, object: impl FromGlibPtrNone for const #291

Merged
merged 1 commit into from Feb 7, 2018

Conversation

Projects
None yet
4 participants
@MathieuDuponchelle
Contributor

MathieuDuponchelle commented Feb 7, 2018

No description provided.

@sdroege

This comment has been minimized.

Member

sdroege commented Feb 7, 2018

👍

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 7, 2018

Thanks! Just waiting for CI and I merge (unless @EPashkin finds something wrong).

@sdroege

This comment has been minimized.

Member

sdroege commented Feb 7, 2018

Ah, pango has some manual implementations of that trait...

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 7, 2018

@GuillaumeGomez 👍 It normal that build fails
@MathieuDuponchelle https://github.com/gtk-rs/pango will need fix after this merged.

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 7, 2018

I merge then!

@GuillaumeGomez GuillaumeGomez merged commit 3fe8f40 into gtk-rs:master Feb 7, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@MathieuDuponchelle

This comment has been minimized.

Contributor

MathieuDuponchelle commented Feb 9, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment