New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate CallbackGuard #293

Merged
merged 1 commit into from Feb 18, 2018

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented Feb 17, 2018

Part of #250

cc @GuillaumeGomez

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 17, 2018

👍

1 similar comment
@sdroege

This comment has been minimized.

Member

sdroege commented Feb 17, 2018

👍

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 17, 2018

Oh, it since 1.23. I fix deprecation text

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 17, 2018

Updated

@@ -54,20 +54,24 @@ impl ToGlib for Continue {
/// Unwinding propagation guard. Aborts the process if destroyed while
/// panicking.
#[deprecated(note="Rustc has this functionality buildin since 1.23.0")]

This comment has been minimized.

@sdroege

sdroege Feb 17, 2018

Member

Since 1.24

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 17, 2018

rust-lang/rust@51b47dc contains in branches started from rust-lang/rust@d0f1f42 and rust-lang/rust@2dad872 but not in rust-lang/rust@5041b3b

Strange that for me https://github.com/rust-lang/rust/releases/tag/1.23.0 not in current repo

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 17, 2018

@sdroege Maybe you right, I use "Aaron Power" commits

@sdroege

This comment has been minimized.

Member

sdroege commented Feb 17, 2018

Also it's in the 1.24 release notes

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 17, 2018

You right, I checked by tag archive too. I will change back

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 17, 2018

Updated

@sdroege

This comment has been minimized.

Member

sdroege commented Feb 17, 2018

Great :)

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 17, 2018

All good to go now?

@sdroege

This comment has been minimized.

Member

sdroege commented Feb 17, 2018

From my side yes

@@ -54,20 +54,24 @@ impl ToGlib for Continue {
/// Unwinding propagation guard. Aborts the process if destroyed while
/// panicking.
#[deprecated(note="Rustc has this functionality buildin since 1.24.0")]

This comment has been minimized.

@sdroege

sdroege Feb 17, 2018

Member

"builtin" or "built-in"

This comment has been minimized.

@EPashkin

EPashkin Feb 17, 2018

Member

Thanks, fixed

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 18, 2018

For me PR also ready for merge

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 18, 2018

Thanks then!

@GuillaumeGomez GuillaumeGomez merged commit 38adf3f into gtk-rs:master Feb 18, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:deprecate_CallbackGuard branch Feb 18, 2018

@EPashkin EPashkin referenced this pull request Jun 23, 2018

Merged

Deprecate CallbackGuard #341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment