New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ptr::NonNull for Boxed/Shared wrappers #303

Merged
merged 1 commit into from Apr 11, 2018

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Mar 29, 2018

This allows the compiler to optimize better, and in our case these
pointers are guaranteed to be not NULL.

Requires Rust 1.25. We might want to do the same for Stash maybe, or even the translation traits. But that's far more intrusive.

Use ptr::NonNull for Boxed/Shared wrappers
This allows the compiler to optimize better, and in our case these
pointers are guaranteed to be not NULL.
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 29, 2018

Member

Very good, but IMHO better wait for stable 1.26 or even 1.27

Member

EPashkin commented Mar 29, 2018

Very good, but IMHO better wait for stable 1.26 or even 1.27

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Mar 30, 2018

Member

You mean to prevent another annoyance like with the callback guards?

Member

sdroege commented Mar 30, 2018

You mean to prevent another annoyance like with the callback guards?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 30, 2018

Member

Yes

Member

EPashkin commented Mar 30, 2018

Yes

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Apr 1, 2018

Member

Ok, not that important in any case :) I updated GStreamer to use it already though

Member

sdroege commented Apr 1, 2018

Ok, not that important in any case :) I updated GStreamer to use it already though

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 11, 2018

Member

Then I'll merge it as well (you should have remind me this one! ><).

Member

GuillaumeGomez commented Apr 11, 2018

Then I'll merge it as well (you should have remind me this one! ><).

@GuillaumeGomez GuillaumeGomez merged commit f2cdad1 into gtk-rs:master Apr 11, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment