New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dox #315

Merged
merged 3 commits into from Apr 20, 2018

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Apr 16, 2018

No description provided.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Apr 16, 2018

Member

👍

Member

sdroege commented Apr 16, 2018

👍

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 16, 2018

Member

@sdroege: Two tests are failing, any idea what's happening?

Member

GuillaumeGomez commented Apr 16, 2018

@sdroege: Two tests are failing, any idea what's happening?

// See the COPYRIGHT file at the top-level directory of this distribution.
// Licensed under the MIT license, see the LICENSE file or <http://opensource.org/licenses/MIT>
use std::cell::RefCell;
use std::mem::transmute;
#[cfg(any(all(feature = "v2_36", unix), feature = "dox"))]
#[cfg(any(feature = "v2_36", unix))]
use std::os::unix::io::RawFd;

This comment has been minimized.

@EPashkin

EPashkin Apr 17, 2018

Member

This is produce unused warning on travis linux 3.4

@EPashkin

EPashkin Apr 17, 2018

Member

This is produce unused warning on travis linux 3.4

Show outdated Hide outdated .travis.yml
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 17, 2018

Member

We have test main_context::tests::test_invoke stalling again.
For the first time I see so many of this in single CI run.

Member

EPashkin commented Apr 17, 2018

We have test main_context::tests::test_invoke stalling again.
For the first time I see so many of this in single CI run.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Apr 17, 2018

Member

Also test_paths is failing for some reason, maybe because of travis using symbolic links and one of the parts resolving them?

---- translate::tests::test_paths stdout ----
	thread 'translate::tests::test_paths' panicked at 'assertion failed: `(left == right)`
  left: `Some("/private/var/folders/bb/n7t3rs157850byt_jfdcq9k80000gn/T/glib-test.7UEbO9t321jY")`,
 right: `Some("/var/folders/bb/n7t3rs157850byt_jfdcq9k80000gn/T/glib-test.7UEbO9t321jY")`', src/translate.rs:1521:9
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failures:
    translate::tests::test_paths
Member

sdroege commented Apr 17, 2018

Also test_paths is failing for some reason, maybe because of travis using symbolic links and one of the parts resolving them?

---- translate::tests::test_paths stdout ----
	thread 'translate::tests::test_paths' panicked at 'assertion failed: `(left == right)`
  left: `Some("/private/var/folders/bb/n7t3rs157850byt_jfdcq9k80000gn/T/glib-test.7UEbO9t321jY")`,
 right: `Some("/var/folders/bb/n7t3rs157850byt_jfdcq9k80000gn/T/glib-test.7UEbO9t321jY")`', src/translate.rs:1521:9
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failures:
    translate::tests::test_paths
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Apr 17, 2018

Member

And also build failing due to missing xcb-shm:

+cargo build --features gtk_3_18 --jobs 1
[...]
error: failed to run custom build command for `cairo-sys-rs v0.6.0 (https://github.com/gtk-rs/cairo#7b52ef54)`
process didn't exit successfully: `/Users/travis/build/gtk-rs/glib/_examples/target/debug/build/cairo-sys-rs-5454e01fbd6b4aa1/build-script-build` (exit code: 1)
--- stderr
`"pkg-config" "--libs" "--cflags" "cairo >= 1.10"` did not exit successfully: exit code: 1
--- stderr
Package xcb-shm was not found in the pkg-config search path.
Perhaps you should add the directory containing `xcb-shm.pc'
to the PKG_CONFIG_PATH environment variable
Package 'xcb-shm', required by 'cairo', not found

So many things at once!

Member

sdroege commented Apr 17, 2018

And also build failing due to missing xcb-shm:

+cargo build --features gtk_3_18 --jobs 1
[...]
error: failed to run custom build command for `cairo-sys-rs v0.6.0 (https://github.com/gtk-rs/cairo#7b52ef54)`
process didn't exit successfully: `/Users/travis/build/gtk-rs/glib/_examples/target/debug/build/cairo-sys-rs-5454e01fbd6b4aa1/build-script-build` (exit code: 1)
--- stderr
`"pkg-config" "--libs" "--cflags" "cairo >= 1.10"` did not exit successfully: exit code: 1
--- stderr
Package xcb-shm was not found in the pkg-config search path.
Perhaps you should add the directory containing `xcb-shm.pc'
to the PKG_CONFIG_PATH environment variable
Package 'xcb-shm', required by 'cairo', not found

So many things at once!

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Apr 17, 2018

Member

The main context thing is probably fixed by #316

Member

sdroege commented Apr 17, 2018

The main context thing is probably fixed by #316

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Apr 17, 2018

Member

Someone kick CI, everything but the xcb-shm problem should be gone now

Member

sdroege commented Apr 17, 2018

Someone kick CI, everything but the xcb-shm problem should be gone now

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 17, 2018

Member

I restarted one already. :)

Member

GuillaumeGomez commented Apr 17, 2018

I restarted one already. :)

Show outdated Hide outdated src/translate.rs
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 20, 2018

Member

It finally passed! Good to merge or anything that might need to be changed?

Member

GuillaumeGomez commented Apr 20, 2018

It finally passed! Good to merge or anything that might need to be changed?

- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew update; fi
- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew unlink python; fi
- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew install gtk+3 cairo atk; fi
- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig:/opt/X11/lib/pkgconfig; fi

This comment has been minimized.

@EPashkin

EPashkin Apr 20, 2018

Member

Separate ifs with same condition is special?

@EPashkin

EPashkin Apr 20, 2018

Member

Separate ifs with same condition is special?

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Apr 20, 2018

Member

Just more readable (from my point of view).

@GuillaumeGomez

GuillaumeGomez Apr 20, 2018

Member

Just more readable (from my point of view).

This comment has been minimized.

@EPashkin

EPashkin Apr 20, 2018

Member

IMHO multi-line commands is allowed.
Currently only found not full multi-command example in https://github.com/gtk-rs/gio/blob/master/.travis.yml#L15-L17,
but I seen real multiple commands somewhere.

@EPashkin

EPashkin Apr 20, 2018

Member

IMHO multi-line commands is allowed.
Currently only found not full multi-command example in https://github.com/gtk-rs/gio/blob/master/.travis.yml#L15-L17,
but I seen real multiple commands somewhere.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 20, 2018

Member

@GuillaumeGomez Its good.
If you don't plan squash commits, please rename "don't test 3.18" to "don't test 3.18 on osx"

Member

EPashkin commented Apr 20, 2018

@GuillaumeGomez Its good.
If you don't plan squash commits, please rename "don't test 3.18" to "don't test 3.18 on osx"

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 20, 2018

Member

I'll squash/rename.

Member

GuillaumeGomez commented Apr 20, 2018

I'll squash/rename.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 20, 2018

Member

And done.

Member

GuillaumeGomez commented Apr 20, 2018

And done.

@GuillaumeGomez GuillaumeGomez merged commit b11d416 into master Apr 20, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the fix-dox branch Apr 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment