New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark g_main_context_default as non-nullable. #316

Merged
merged 1 commit into from Apr 17, 2018

Conversation

Projects
None yet
3 participants
@tmiasko
Contributor

tmiasko commented Apr 17, 2018

The default main context is always available and non-null. Also run
test in a new separate context to avoid interference between tests.

Mark g_main_context_default as non-nullable.
The default main context is always available and non-null. Also run
test in a new separate context to avoid interference between tests.
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Apr 17, 2018

Member

Ah that's the reason for the test failures! I also ran into that with the Futures test and fixed it like that.

Go for it :)

Member

sdroege commented Apr 17, 2018

Ah that's the reason for the test failures! I also ran into that with the Futures test and fixed it like that.

Go for it :)

@sdroege sdroege referenced this pull request Apr 17, 2018

Merged

Fix dox #315

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege
Member

sdroege commented Apr 17, 2018

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez
Member

GuillaumeGomez commented Apr 17, 2018

Yeay!

@GuillaumeGomez GuillaumeGomez merged commit 76059d4 into gtk-rs:master Apr 17, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment