New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unittests on macOS #318

Merged
merged 1 commit into from Apr 17, 2018

Conversation

Projects
None yet
4 participants
@philn
Contributor

philn commented Apr 17, 2018

No description provided.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Apr 17, 2018

Member

👍

Member

sdroege commented Apr 17, 2018

👍

@GuillaumeGomez GuillaumeGomez merged commit 3cb82ed into gtk-rs:master Apr 17, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tmiasko

This comment has been minimized.

Show comment
Hide comment
@tmiasko

tmiasko Apr 17, 2018

Contributor

It seems that MacOS was fixed, but now Windows is broken ;-)

---- translate::tests::test_paths stdout ----
	thread 'translate::tests::test_paths' panicked at 'assertion failed: `(left == right)`
  left: `Some("C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\glib-test.cdycPQvPjmiL")`,
 right: `Some("\\\\?\\C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\glib-test.cdycPQvPjmiL")`', src\translate.rs:1521:9

From https://ci.appveyor.com/project/GuillaumeGomez/glib-l2j1a/build/1.0.655/job/9ma7ne925oh991a5

Contributor

tmiasko commented Apr 17, 2018

It seems that MacOS was fixed, but now Windows is broken ;-)

---- translate::tests::test_paths stdout ----
	thread 'translate::tests::test_paths' panicked at 'assertion failed: `(left == right)`
  left: `Some("C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\glib-test.cdycPQvPjmiL")`,
 right: `Some("\\\\?\\C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\glib-test.cdycPQvPjmiL")`', src\translate.rs:1521:9

From https://ci.appveyor.com/project/GuillaumeGomez/glib-l2j1a/build/1.0.655/job/9ma7ne925oh991a5

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 17, 2018

Member

Wuuuuuuuuuut

Member

GuillaumeGomez commented Apr 17, 2018

Wuuuuuuuuuut

@tmiasko

This comment has been minimized.

Show comment
Hide comment
@tmiasko

tmiasko Apr 17, 2018

Contributor

Let me retest that, I am not sure I was rebased properly. (Job is "running" at https://ci.appveyor.com/project/GuillaumeGomez/glib/build/1.0.651)

Contributor

tmiasko commented Apr 17, 2018

Let me retest that, I am not sure I was rebased properly. (Job is "running" at https://ci.appveyor.com/project/GuillaumeGomez/glib/build/1.0.651)

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Apr 17, 2018

Member

Ah nice. For some context:

commit 5624c9d
Author: Sebastian Dröge sebastian@centricular.com
Date: Tue Dec 5 17:01:07 2017 +0200

Handle "long path" paths starting with "\\?\" on Windows correctly

On Windows, paths can have \\?\ prepended for long-path support. See
the MSDN documentation about CreateFile, for example

We have to get rid of this and let GLib take care of all these
weirdnesses later
Member

sdroege commented Apr 17, 2018

Ah nice. For some context:

commit 5624c9d
Author: Sebastian Dröge sebastian@centricular.com
Date: Tue Dec 5 17:01:07 2017 +0200

Handle "long path" paths starting with "\\?\" on Windows correctly

On Windows, paths can have \\?\ prepended for long-path support. See
the MSDN documentation about CreateFile, for example

We have to get rid of this and let GLib take care of all these
weirdnesses later
@philn

This comment has been minimized.

Show comment
Hide comment
@philn

philn Apr 18, 2018

Contributor

Sorry :)

Contributor

philn commented Apr 18, 2018

Sorry :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment