Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic error in futures wakeup that caused them to often not be woken up #329

Merged
merged 2 commits into from Apr 23, 2018

Conversation

Projects
None yet
2 participants
@sdroege
Copy link
Member

sdroege commented Apr 23, 2018

And add a test for this, which reproduced it most of the time.

sdroege added some commits Apr 23, 2018

Don't require the main context by mutable reference when spawning fut…
…ures

It's simply not required, the main context uses interior mutability
Fix logic error in futures wakeup that caused them to often not be wo…
…ken up

And add a test for this, which reproduced it most of the time.

@GuillaumeGomez GuillaumeGomez merged commit 7eda639 into gtk-rs:master Apr 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.