New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark MainContext::ref_thread_default() as non-nullable with regards t… #333

Merged
merged 3 commits into from May 7, 2018

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented May 6, 2018

…o the return value

Fixes #332

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 6, 2018

Member

Confirming that both this PR and gtk-rs/gio#117 builds locally for Windows for v3.22 and futures.

Member

EPashkin commented May 6, 2018

Confirming that both this PR and gtk-rs/gio#117 builds locally for Windows for v3.22 and futures.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege May 7, 2018

Member

@GuillaumeGomez let's get this and gtk-rs/gio#117 and in then?

Member

sdroege commented May 7, 2018

@GuillaumeGomez let's get this and gtk-rs/gio#117 and in then?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez
Member

GuillaumeGomez commented May 7, 2018

Yup!

@GuillaumeGomez GuillaumeGomez merged commit 4344176 into gtk-rs:master May 7, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment