New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use from_glib_none() in Object::new() if the object is actually … #335

Merged
merged 1 commit into from May 9, 2018

Conversation

Projects
None yet
4 participants
@sdroege
Member

sdroege commented May 9, 2018

…floating

Some GObjects are based on GInitiallyUnowned but their constructor
functions return an already sunken floating reference.

Only use from_glib_none() in Object::new() if the object is actually …
…floating

Some GObjects are based on GInitiallyUnowned but their constructor
functions return an already sunken floating reference.
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez
Member

GuillaumeGomez commented May 9, 2018

👍

@tmiasko

This comment has been minimized.

Show comment
Hide comment
@tmiasko

tmiasko May 9, 2018

Contributor

I would presume that those kind of problems don't happen other way around,
so that looks reasonable.

It is somewhat unfortunate that we have to put workarounds like that,
could you give some examples where this happens?

Contributor

tmiasko commented May 9, 2018

I would presume that those kind of problems don't happen other way around,
so that looks reasonable.

It is somewhat unfortunate that we have to put workarounds like that,
could you give some examples where this happens?

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege May 9, 2018

Member

Also floating references are just a workaround and historical mistake because people were too lazy 15 years ago to change a lot of GTK-based code. It's a disaster :)

Member

sdroege commented May 9, 2018

Also floating references are just a workaround and historical mistake because people were too lazy 15 years ago to change a lot of GTK-based code. It's a disaster :)

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 9, 2018

Member

@sdroege Thanks, all LGFM

Member

EPashkin commented May 9, 2018

@sdroege Thanks, all LGFM

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege May 9, 2018

Member

@GuillaumeGomez let's get this in then :)

Member

sdroege commented May 9, 2018

@GuillaumeGomez let's get this in then :)

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 9, 2018

Member

Yup, thanks!

Member

GuillaumeGomez commented May 9, 2018

Yup, thanks!

@GuillaumeGomez GuillaumeGomez merged commit 126457f into gtk-rs:master May 9, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment