New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose signal::signal_handler_disconnect #342

Merged
merged 1 commit into from Jun 23, 2018

Conversation

Projects
None yet
3 participants
@philn
Contributor

philn commented Jun 23, 2018

No description provided.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 23, 2018

Member

@philn Thanks
👍

Member

EPashkin commented Jun 23, 2018

@philn Thanks
👍

@philn

This comment has been minimized.

Show comment
Hide comment
@philn

philn Jun 23, 2018

Contributor

BTW why is this function not taking a reference like the others?

Contributor

philn commented Jun 23, 2018

BTW why is this function not taking a reference like the others?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 23, 2018

Member

Because disconnecting can be happened only one time

Member

EPashkin commented Jun 23, 2018

Because disconnecting can be happened only one time

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 23, 2018

Member

So we all agree. Thanks @philn!

Member

GuillaumeGomez commented Jun 23, 2018

So we all agree. Thanks @philn!

@GuillaumeGomez GuillaumeGomez merged commit 2162af3 into gtk-rs:master Jun 23, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@philn philn deleted the philn:patch-1 branch Jun 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment