Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings #343

Merged
merged 1 commit into from Jun 24, 2018

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

EPashkin commented Jun 24, 2018

@@ -26,7 +26,7 @@ impl MainContext {
}
}

pub fn find_source_by_id(&self, source_id: SourceId) -> Option<Source> {
pub fn find_source_by_id(&self, source_id: &SourceId) -> Option<Source> {

This comment has been minimized.

@EPashkin

EPashkin Jun 24, 2018

Author Member

@sdroege Strange why find want consume non-copy type

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Jun 24, 2018

Member

That's very weird because I assume that we can get the SourceId from the Source. However, if no Source matches the SourceId, you just don't have the SourceId anymore... Maybe it is the purpose?

This comment has been minimized.

@sdroege

sdroege Jun 24, 2018

Member

Should be by reference, yes

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jun 24, 2018

👍

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jun 24, 2018

Looks good to me

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jun 24, 2018

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit d51bd06 into gtk-rs:master Jun 24, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@EPashkin EPashkin deleted the EPashkin:clippy_warnings branch Jun 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.