New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use futures-preview crates instead of futures #345

Merged
merged 1 commit into from Jun 27, 2018

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Jun 27, 2018

The futures crates were janked from crates.io and renamed to
futures-preview for whatever reason.

The other crates and gir need to be updated next. Useless code churn.

See https://users.rust-lang.org/t/futures-0-2-has-been-moved-to-futures-preview/18329 for context

Use futures-preview crates instead of futures
The futures crates were janked from crates.io and renamed to
futures-preview for whatever reason.
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 27, 2018

Member

CI is failing, is it expected?

Member

GuillaumeGomez commented Jun 27, 2018

CI is failing, is it expected?

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 27, 2018

Member

Yes, we need to update all the crates to the new crate names. Great release management in the name of not breaking anything

Member

sdroege commented Jun 27, 2018

Yes, we need to update all the crates to the new crate names. Great release management in the name of not breaking anything

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 27, 2018

Member

@sdroege Thanks.
For working CI seems enough update gio and examples.
after this gdk-pixbuf, gtk and sourceview will be good.

Member

EPashkin commented Jun 27, 2018

@sdroege Thanks.
For working CI seems enough update gio and examples.
after this gdk-pixbuf, gtk and sourceview will be good.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 27, 2018

Member

Although still without futures-nightly

Member

EPashkin commented Jun 27, 2018

Although still without futures-nightly

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 27, 2018

Member

Then I merge. Thanks!

Member

GuillaumeGomez commented Jun 27, 2018

Then I merge. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 18a2ed6 into gtk-rs:master Jun 27, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 27, 2018

Member

Although still without futures-nightly

This one also compiles with latest nightly fortunately, or what do you mean?

Member

sdroege commented Jun 27, 2018

Although still without futures-nightly

This one also compiles with latest nightly fortunately, or what do you mean?

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 27, 2018

Member

For working CI seems enough update gio and examples.

Yes

Member

sdroege commented Jun 27, 2018

For working CI seems enough update gio and examples.

Yes

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jun 27, 2018

Member

@sdroege I meant with examples/futures-nightly.
Enabling it still failing even with latest nightly:

error[E0277]: the trait bound `F: core::marker::Unpin` is not satisfied
   --> C:\Users\eap\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-core-preview-0.2.2\src\future\mod.rs:150:22
    |
150 |             unsafe { ::core::mem::PinMut::get_mut(self.as_pin_mut()).poll(cx) }
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `core::marker::Unpin` is not implemented for `F`
    |
    = help: consider adding a `where F: core::marker::Unpin` bound
    = note: required by `<core::mem::PinMut<'a, T>>::get_mut`
Member

EPashkin commented Jun 27, 2018

@sdroege I meant with examples/futures-nightly.
Enabling it still failing even with latest nightly:

error[E0277]: the trait bound `F: core::marker::Unpin` is not satisfied
   --> C:\Users\eap\.cargo\registry\src\github.com-1ecc6299db9ec823\futures-core-preview-0.2.2\src\future\mod.rs:150:22
    |
150 |             unsafe { ::core::mem::PinMut::get_mut(self.as_pin_mut()).poll(cx) }
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `core::marker::Unpin` is not implemented for `F`
    |
    = help: consider adding a `where F: core::marker::Unpin` bound
    = note: required by `<core::mem::PinMut<'a, T>>::get_mut`
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 27, 2018

Member

Yes you have to use futures from git for that unfortunately. It's really impressively badly managed :)

Member

sdroege commented Jun 27, 2018

Yes you have to use futures from git for that unfortunately. It's really impressively badly managed :)

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 27, 2018

Member

I'll try to send the other ones some time later today, but feel free to do it. It's mostly a matter of appending '-preview' to the crate names in Cargo.toml.

Member

sdroege commented Jun 27, 2018

I'll try to send the other ones some time later today, but feel free to do it. It's mostly a matter of appending '-preview' to the crate names in Cargo.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment