New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with two-phase-borrows (aka NLL) #368

Merged
merged 1 commit into from Aug 8, 2018

Conversation

Projects
None yet
2 participants
@sdroege
Member

sdroege commented Aug 8, 2018

No description provided.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 8, 2018

Member

Why this change btw?

Member

GuillaumeGomez commented Aug 8, 2018

Why this change btw?

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Aug 8, 2018

Member

Because otherwise we would mutably borrow from something behind a const pointer, and that's not allowed and mistakingly works with the old borrow checker :)

Member

sdroege commented Aug 8, 2018

Because otherwise we would mutably borrow from something behind a const pointer, and that's not allowed and mistakingly works with the old borrow checker :)

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 8, 2018

Member

Ok! Thanks!

Member

GuillaumeGomez commented Aug 8, 2018

Ok! Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 7d9217b into gtk-rs:master Aug 8, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment