New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various Send/Sync impls where appropriate #372

Merged
merged 2 commits into from Aug 29, 2018

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Aug 29, 2018

No description provided.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 29, 2018

Member

New problem with futures (again) apparently. Otherwise seems good to me, thanks!

Member

GuillaumeGomez commented Aug 29, 2018

New problem with futures (again) apparently. Otherwise seems good to me, thanks!

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 29, 2018

Member

👍 too. Thanks, @sdroege

Member

EPashkin commented Aug 29, 2018

👍 too. Thanks, @sdroege

@GuillaumeGomez GuillaumeGomez merged commit 79110c8 into gtk-rs:master Aug 29, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 29, 2018

Member

Note:
Examples IMHO compiles on (I was build only one binary so not sure)
rustc 1.30.0-nightly (d41f21f11 2018-08-24)
binary: rustc
commit-hash: d41f21f11a249ad78990eb9a1ec899ec123c7136

But produce same error on
rustc 1.30.0-nightly (7061b2775 2018-08-28)
binary: rustc
commit-hash: 7061b2775782bb48c0a70d3c79ec711134396687
commit-date: 2018-08-28
host: x86_64-pc-windows-gnu

Member

EPashkin commented Aug 29, 2018

Note:
Examples IMHO compiles on (I was build only one binary so not sure)
rustc 1.30.0-nightly (d41f21f11 2018-08-24)
binary: rustc
commit-hash: d41f21f11a249ad78990eb9a1ec899ec123c7136

But produce same error on
rustc 1.30.0-nightly (7061b2775 2018-08-28)
binary: rustc
commit-hash: 7061b2775782bb48c0a70d3c79ec711134396687
commit-date: 2018-08-28
host: x86_64-pc-windows-gnu

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Aug 30, 2018

Member

I would propose to remove the futures-nightly test from travis. futures 0.2 is not maintained any longer and futures 0.3 needs a nightly compiler so I wouldn't be happy to generally port thing to that.

Maybe we can have a futures 0.2 feature for stable in glib, and a futures 0.3 feature for nightly. Probably means duplicating the two _futures.rs files though.

Opinions?

Member

sdroege commented Aug 30, 2018

I would propose to remove the futures-nightly test from travis. futures 0.2 is not maintained any longer and futures 0.3 needs a nightly compiler so I wouldn't be happy to generally port thing to that.

Maybe we can have a futures 0.2 feature for stable in glib, and a futures 0.3 feature for nightly. Probably means duplicating the two _futures.rs files though.

Opinions?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 30, 2018

Member

If futures-preview 0.2 don't get fixes anymore,
then IMHO we really can just ignore future-nightly as it currently don't add any new functional.
So I vote for removing it from testing until crate be more stable.

Member

EPashkin commented Aug 30, 2018

If futures-preview 0.2 don't get fixes anymore,
then IMHO we really can just ignore future-nightly as it currently don't add any new functional.
So I vote for removing it from testing until crate be more stable.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 30, 2018

Member

I agree, let's comment tests for now.

Member

GuillaumeGomez commented Aug 30, 2018

I agree, let's comment tests for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment