New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to the futures crate instead of individual crates and re-export … #375

Merged
merged 1 commit into from Sep 5, 2018

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Sep 5, 2018

…from here

Re-exporting makes it easier for people to mix futures 0.2 and futures
0.1/0.3 in the same application as inside Cargo.toml only one can be
specified. This allows to use e.g. tokio and GLib futures easily in the
same application.

CC @alatiera

Move to the futures crate instead of individual crates and re-export …
…from here

Re-exporting makes it easier for people to mix futures 0.2 and futures
0.1/0.3 in the same application as inside Cargo.toml only one can be
specified. This allows to use e.g. tokio and GLib futures easily in the
same application.
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Sep 5, 2018

Member

Well, at least it's shorter. :)

Member

GuillaumeGomez commented Sep 5, 2018

Well, at least it's shorter. :)

Show resolved Hide resolved src/lib.rs
@alatiera

This comment has been minimized.

Show comment
Hide comment
@alatiera

alatiera Sep 5, 2018

This looks nice, thanks a lot for taking the time and doing it!

alatiera commented Sep 5, 2018

This looks nice, thanks a lot for taking the time and doing it!

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Sep 5, 2018

Member

I have a WIP branch for futures 0.3 FWIW, it requires quite some changes. But that's for some future release.

Member

sdroege commented Sep 5, 2018

I have a WIP branch for futures 0.3 FWIW, it requires quite some changes. But that's for some future release.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Sep 5, 2018

Member

Good to go @GuillaumeGomez

Member

sdroege commented Sep 5, 2018

Good to go @GuillaumeGomez

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez
Member

GuillaumeGomez commented Sep 5, 2018

Ok!

@GuillaumeGomez GuillaumeGomez merged commit 9bda2d9 into gtk-rs:master Sep 5, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment