Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require fewer trait bounds for WeakRef and the ObjectExt trait #401

Merged
merged 2 commits into from Nov 29, 2018

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

sdroege commented Nov 28, 2018

This is a very first part of gtk-rs/gir#670

Require 'static for the IsA trait
And remove Sized bound for Cast::downcast_ref()

@sdroege sdroege force-pushed the sdroege:fewer-bounds branch from 2b3e922 to f49506d Nov 28, 2018

Show resolved Hide resolved src/object.rs
Require fewer trait bounds for WeakRef and the ObjectExt trait
And remove the ?Sized bound from WeakRef. We can't really work with
unsized/dynamically sized types for now so don't claim to be able to do
so.

@sdroege sdroege force-pushed the sdroege:fewer-bounds branch from f49506d to e050d4f Nov 29, 2018

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Nov 29, 2018

@sdroege Thanks, 👍

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Nov 29, 2018

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit a37ffcd into gtk-rs:master Nov 29, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.