Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to get the implementation from an instance #403

Merged
merged 2 commits into from Dec 4, 2018

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

sdroege commented Dec 4, 2018

This allows to get the implementation safely without going via the
instance struct first by directly calling it on the wrapper type.

Show resolved Hide resolved src/subclass/types.rs Outdated

sdroege added some commits Dec 4, 2018

Add function to get the implementation from an instance
This allows to get the implementation safely without going via the
instance struct first by directly calling it on the wrapper type.

@sdroege sdroege force-pushed the sdroege:impl-from-instance branch from 3ab6029 to f59228d Dec 4, 2018

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Dec 4, 2018

Looks good to me, thanks!

cc @EPashkin

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Dec 4, 2018

@GuillaumeGomez all green :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Dec 4, 2018

Just waiting for @EPashkin to take a look first in case I missed something.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Dec 4, 2018

@sdroege Thanks
👍

@GuillaumeGomez GuillaumeGomez merged commit dfdfa67 into gtk-rs:master Dec 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.