Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subclassing test for registering signals, action signals, emittin… #404

Merged
merged 1 commit into from Dec 4, 2018

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

sdroege commented Dec 4, 2018

…g, signals, etc.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Dec 4, 2018

Looks good to me! (Maybe changing the unwrap calls?)

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Dec 4, 2018

@sdroege Thanks, LGFM

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Dec 4, 2018

Maybe changing the unwrap calls?

I think those are fine :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Dec 4, 2018

I'm just nitpicking considering they are in the test. :)

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Dec 4, 2018

All green :)

@GuillaumeGomez GuillaumeGomez merged commit 63b5499 into gtk-rs:master Dec 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Dec 4, 2018

All merged! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.