Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes compilation on aarch64 #413

Merged
merged 1 commit into from Dec 18, 2018

Conversation

Projects
None yet
3 participants
@bkchr
Copy link
Contributor

bkchr commented Dec 18, 2018

c_char on aarch64 is a u8.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Dec 18, 2018

👍

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Dec 18, 2018

Go go go :)

I wonder how often we have to fail with u8 vs. i8 for c_char, and how we can prevent that in the future... we need ARM CI. Should set one up for GStreamer one of these days

@bkchr

This comment has been minimized.

Copy link
Contributor Author

bkchr commented Dec 18, 2018

Maybe at least a CI that cross compiles for arm ^^

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Dec 18, 2018

I'll open an issue for that and try to add such a test *soon*. If anyone feels like adding it, please go ahead. :D

@GuillaumeGomez GuillaumeGomez merged commit ec97174 into gtk-rs:master Dec 18, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bkchr bkchr deleted the bkchr:fix_aarch64 branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.