Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for implementing GObject interfaces generically #415

Merged
merged 1 commit into from Dec 19, 2018

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

sdroege commented Dec 18, 2018

Fixes #408

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Dec 19, 2018

@sdroege let data = &mut *data.as_mut(); why not just let data = data.as_mut(); ?

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Dec 19, 2018

@sdroege let data = &mut *data.as_mut(); why not just let data = data.as_mut(); ?

Leftover from previous versions. Changed that, thanks :)

Apart from that the change looks fine to you, @EPashkin? I mean the parts especially

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Dec 19, 2018

Yes, all other looks good for me

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Dec 19, 2018

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 25ec6f3 into gtk-rs:master Dec 19, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.