Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various signal subclass improvements #444

Merged
merged 4 commits into from Feb 7, 2019

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

sdroege commented Feb 6, 2019

No description provided.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 6, 2019

👍

@sdroege sdroege force-pushed the sdroege:signal-class-handler branch from fa6124f to 57d26c4 Feb 6, 2019

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Feb 6, 2019

👍 Thanks

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 6, 2019

error[E0433]: failed to resolve: could not find `unix` in `os`
 --> src\source.rs:8:14
  |
8 | use std::os::unix::io::RawFd;
  |              ^^^^ could not find `unix` in `os`
error: Compilation failed, aborting rustdoc
@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 7, 2019

error[E0433]: failed to resolve: could not find `unix` in `os`

Should be fixed now, let's see

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 7, 2019

Yeah that part is fixed, now we only have the general CI setup being broken left (and the examples PR must be merged).

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 7, 2019

Merging then, let's figure out the CI in another PR (and on some parts @EPashkin is already working).

@sdroege sdroege merged commit 697f46c into gtk-rs:master Feb 7, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.