Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For setting properties and the return value of signal handlers relax … #457

Merged
merged 1 commit into from Feb 21, 2019

Conversation

Projects
None yet
2 participants
@sdroege
Copy link
Member

sdroege commented Feb 21, 2019

…the type checks

Instead of requiring that the type of the Value itself has to be
compatible, we are checking for Object subclasses also if the type of
the contained object is compatible and if it is make sure that
everything works correctly.

This can happen for example if a button is stored in a gtk::Widget typed
variable and then converted to a glib::Value. The Value will have the
type of Widget and not Button, and type checks would fail.

For setting properties and the return value of signal handlers relax …
…the type checks

Instead of requiring that the type of the Value itself has to be
compatible, we are checking for Object subclasses also if the type of
the contained object is compatible and if it is make sure that
everything works correctly.

This can happen for example if a button is stored in a gtk::Widget typed
variable and then converted to a glib::Value. The Value will have the
type of Widget and not Button, and type checks would fail.
@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 21, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 21, 2019

👍

@sdroege sdroege merged commit 7cb6ad1 into gtk-rs:master Feb 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.