Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use deprecated ATOMIC_USIZE_INIT #461

Merged
merged 1 commit into from Feb 22, 2019

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

commented Feb 21, 2019

fn next_thread_id() -> usize {
static mut COUNTER: AtomicUsize = ATOMIC_USIZE_INIT;
static mut COUNTER: AtomicUsize = AtomicUsize::new(0);

This comment has been minimized.

Copy link
@sdroege

sdroege Feb 21, 2019

Member

Ah is this stabilized since 1.31 already (constified constructor)? I thought it was later :)

👍 if it builds with 1.31

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

👍

@sdroege

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

@GuillaumeGomez the examples repo is confused with regards to versions, can you update that? :) See CI failures

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2019

@sdroege IMHO problem in this: gtk-rs/examples#233 (comment)

@sdroege

This comment has been minimized.

Copy link
Member

commented Feb 22, 2019

Indeed

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2019

CI passed

@sdroege sdroege merged commit db6b85e into gtk-rs:master Feb 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:atomic_usize_new branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.