Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing #[doc(hidden)] #471

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Copy link
Member

commented Mar 6, 2019

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:add-missing-doc-hidden branch from b100830 to dcc5fed Mar 6, 2019

@EPashkin

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

👍

@sdroege

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libffi', required by 'gobject-2.0', not found

Travis is unhappy, but only on some configurations. Not sure what the problem there is, libglib2.0-dev should pull in libffi-dev already.


Otherwise looks good to me. Do you have an automated way of finding these, some script?

@EPashkin

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

This seems osx brew packaging problem.
It was not listed as dependency and removed https://travis-ci.org/gtk-rs/glib/jobs/502818085#L1571

@EPashkin

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

@GuillaumeGomez, @sdroege Can we merge this and fix osx in separate PRs?
I plan finish my gtk's PR today and better rebase it to new master to solve merge conflicts.

@EPashkin

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

Oh, sorry, I was sure that #doc[hidden] added to gtk.

@sdroege

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

This seems osx brew packaging problem.
It was not listed as dependency and removed https://travis-ci.org/gtk-rs/glib/jobs/502818085#L1571

libffi is a hard dependency for glib, so that's indeed a brew bug then.

@sdroege

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

@GuillaumeGomez, @sdroege Can we merge this and fix osx in separate PRs?

Sure

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

Then please merge @sdroege :)

@sdroege sdroege merged commit 4a1c35b into gtk-rs:master Mar 7, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:add-missing-doc-hidden branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.