Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to futures 0.3 #476

Merged
merged 1 commit into from Apr 26, 2019

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

commented Apr 26, 2019

While this requires nightly, the API is now stabilized and will become part of Rust 1.36. IMHO we should merge this now so that it can all get wider testing.

@sdroege sdroege referenced this pull request Apr 26, 2019

Merged

Port to futures 0.3 #206

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

Looks good to me, thanks! And yes, the sooner the better.

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

Great, thanks. Waiting for @EPashkin's opinion and the "OK" for all the other PRs and then let's get merging

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

and then let's get merging

Note that I have to update all PRs before merging apart from glib and gir once those two are merged.

@EPashkin

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

@sdroege Big thanks.
As we have some fixes for previous release maybe better do release first?
Then we have 3 month until stable 1.36 for testing.

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

The idea would be to include it in this release already so people actually start testing. Almost nobody is using git :)

@EPashkin

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

Ok

@sdroege sdroege merged commit 66a9c53 into gtk-rs:master Apr 26, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

Ok, then I'll merge this and update the other ones in a bit.

let f: Box<Future<Item = (), Error = Never> + 'static> = Box::from_raw(f);
// Super-unsafe: We transmute here to get rid of the 'static lifetime
let f = LocalFutureObj::new(Box::new(f));
let f: (LocalFutureObj<'static, ()>) = mem::transmute(f);

This comment has been minimized.

Copy link
@EPashkin

EPashkin Apr 26, 2019

Member

IMHO comment now has wrong part "get rid" instead just "get"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.