Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run futures code and tests when building with nightly #477

Merged
merged 3 commits into from Apr 26, 2019

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

commented Apr 26, 2019

No description provided.

@sdroege sdroege force-pushed the sdroege:futures-0.3-tests branch from 857e287 to 2455f12 Apr 26, 2019

@EPashkin

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

Seems this need be after examples

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

No, this fails for other reasons. Will investigate.

The examples might still fail until all PRs are merged though.

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

Yeah, silly :) Because it was stabilized now I need to remove the #![feature] thingy.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

It builds but fails because examples don't have futures feature.

sdroege added some commits Apr 26, 2019

Remove #![feature] gate for futures
The futures API is stabilized now so compilation with latest nightly
gives warnings when using the #![feature] gate for it.

@sdroege sdroege force-pushed the sdroege:futures-0.3-tests branch from 15dab1c to 1581f3d Apr 26, 2019

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

Yeah, I misread. So this is fine and we need to go through the crates one by one as usual and do the examples as the last one.

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

Once gtk-rs/examples#240 is in, this one here should also succeed.

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

@GuillaumeGomez travis is green :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 6d26056 into gtk-rs:master Apr 26, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.