Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate SpawnFlags #487

Merged
merged 1 commit into from May 30, 2019

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

commented May 29, 2019

Part of gtk-rs/gir#784

No new functions generated here,
but allow other crates like vte-rs generate xxx_spawn functions.

cc @GuillaumeGomez

@@ -1036,7 +1036,7 @@ pub fn spawn_command_line_async<P: AsRef<std::ffi::OsStr>>(command_line: P) -> R
// unsafe { TODO: call glib_sys:g_spawn_command_line_sync() }
//}

//pub fn spawn_sync<P: AsRef<std::path::Path>>(working_directory: P, argv: &[&std::path::Path], envp: &[&std::path::Path], flags: /*Ignored*/SpawnFlags, child_setup: Option<Box<dyn FnOnce() + 'static>>, standard_output: Vec<u8>, standard_error: Vec<u8>) -> Result<i32, Error> {
//pub fn spawn_sync<P: AsRef<std::path::Path>>(working_directory: P, argv: &[&std::path::Path], envp: &[&std::path::Path], flags: SpawnFlags, child_setup: Option<Box<dyn FnOnce() + 'static>>, standard_output: Vec<u8>, standard_error: Vec<u8>) -> Result<i32, Error> {

This comment has been minimized.

Copy link
@sdroege

sdroege May 30, 2019

Member

What's missing for this one to be generated? The signature given here is wrong but nonetheless this looks like it should be generatable.

Looks good to me otherwise

@EPashkin EPashkin force-pushed the EPashkin:SpawnFlags branch from aa30cde to 6a7d093 May 30, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

Updated version.txt.
I have no idea why g_spawn_sync not generated

@sdroege

This comment has been minimized.

Copy link
Member

commented May 30, 2019

I have no idea why g_spawn_sync not generated

Can you create an issue for this? Otherwise all good here :) Thanks!

@sdroege sdroege merged commit 47caa98 into gtk-rs:master May 30, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:SpawnFlags branch May 30, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

@Cogitri

This comment has been minimized.

Copy link

commented Jun 2, 2019

Thank you!

@Cogitri Cogitri referenced this pull request Jun 2, 2019

Merged

Regenerate with new GIR #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.