Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init/clear function for boxed types #496

Merged
merged 2 commits into from Jun 13, 2019

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

commented Jun 10, 2019

These allow allocated them on our side and releasing all memory of them
again. It is needed for functions that take an out parameter and require
us to allocate the underlying object.

Fixes https://github.com/gtk-rs/glib/issues/469

sdroege added some commits Jun 10, 2019

Add init/clear function for boxed types
These allow allocated them on our side and releasing all memory of them
again. It is needed for functions that take an out parameter and require
us to allocate the underlying object.

Fixes #469
@sdroege

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

The build failure requires changes in the gtk crate btw, to add these functions to those types there.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

Looks good to me! 👍

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

Looks good to me! +1

#469 (comment) seems fine to you too?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

I didn't see that comment. Seems quite complicated...

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

I didn't see that comment. Seems quite complicated...

Comment that there please :P And it's complicated indeed, but I don't see an easier solution. Shouldn't matter much though as this will only be needed by very few types, and people will notice if it's missing.

@EPashkin

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

@sdroege Thanks again, 👍

@sdroege sdroege merged commit c5e2632 into gtk-rs:master Jun 13, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.