Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement FromGlib and ToGlib traits on Pid type #508

Merged
merged 2 commits into from Jul 22, 2019

Conversation

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jul 20, 2019

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jul 21, 2019

Windows is again against us.
Maybe we need use glib_sys::GPid instead i32 ?

error[E0308]: mismatched types
  --> src\source.rs:57:9
   |
56 |     fn to_glib(&self) -> i32 {
   |                          --- expected `i32` because of return type
57 |         self.0
   |         ^^^^^^ expected i32, found *-ptr
   |
   = note: expected type `i32`
              found type `*mut libc::c_void`
error[E0308]: mismatched types
  --> src\source.rs:65:13
   |
65 |         Pid(val)
   |             ^^^ expected *-ptr, found i32
   |
   = note: expected type `*mut libc::c_void`
              found type `i32`
@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jul 21, 2019

@EPashkin I think too. I'll update the PR.

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:pid-glib-traits branch from 4fb51af to 1596496 Jul 21, 2019
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jul 21, 2019

Wants a cargo fmt apparently, otherwise looks good to me.

Maybe not a good idea to run the cargo fmt CI test with nightly. That should be done with stable or otherwise we get spurious issues like this one whenever there's a rustfmt regression in nightly.

.travis.yml Outdated Show resolved Hide resolved
@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:pid-glib-traits branch from 6191696 to 5bf8b12 Jul 22, 2019
@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jul 22, 2019

👍 @GuillaumeGomez Thanks

@sdroege sdroege merged commit f0589f4 into gtk-rs:master Jul 22, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:pid-glib-traits branch Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.