Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ByteArray::set_size() as unsafe #512

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@sdroege
Copy link
Member

sdroege commented Aug 5, 2019

Just like the version of Vec, this does not actually initialize the
memory if the array has to grow and allows to get uninitialized memory.

The unit test actually caused valgrind warnings because of that.

Also extend unit test a bit.


CC @elmarco @GuillaumeGomez

Just like the version of Vec, this does not actually initialize the
memory if the array has to grow and allows to get uninitialized memory.

The unit test actually caused valgrind warnings because of that.

Also extend unit test a bit.
@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Aug 5, 2019

@sdroege Thanks

@sdroege sdroege merged commit 73bac1a into gtk-rs:master Aug 5, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.