Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

value::GetError: add a constructor and make fields public #517

Merged
merged 2 commits into from Aug 16, 2019

Conversation

@fengalin
Copy link
Contributor

fengalin commented Aug 16, 2019

The constructor allows instantiating the error outside of the module, e.g. for use in an assert_eq!.

People might want to access the public fields when handling the error. Besides, if the error was implemented using an enum, the fields would be public.

Fixes #515

@fengalin

This comment has been minimized.

Copy link
Contributor Author

fengalin commented Aug 16, 2019

Failures on nightly & beta are unreleated. They most probably are a cause by #513 and might explain why it failed on Windows 32bits (they occur in tests subclass::object::test::{test_signal_return_wrong_type, test_signal_return_wrong_object_type}).

I'm on it, and will submit a separate PR.

@fengalin

This comment has been minimized.

Copy link
Contributor Author

fengalin commented Aug 16, 2019

I'll rebase once #519 is merged

fengalin added 2 commits Aug 16, 2019
The constructor allows instantiating the error outside of the module,
e.g. for use in an `assert_eq!`.

People might want to access the public fields when handling the error.
Besides, if the error was implemented using an `enum`, fields would be
public.
@fengalin fengalin force-pushed the fengalin:value_get_error_pub_fields branch from e28a55a to 796e28f Aug 16, 2019
@sdroege sdroege merged commit 3813f4d into gtk-rs:master Aug 16, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fengalin fengalin deleted the fengalin:value_get_error_pub_fields branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.