Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subclass feature #521

Merged
merged 2 commits into from Sep 8, 2019
Merged

Remove subclass feature #521

merged 2 commits into from Sep 8, 2019

Conversation

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Sep 6, 2019

Part of gtk-rs/gtk#887

The second commit is for a better dox support.

cc @sdroege @EPashkin

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Sep 6, 2019

Note that this will break all the other crates. Better get all PRs ready first and then we merge them all at once to keep the time as small as possible during which stuff doesn't build :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Sep 6, 2019

Indeed. I'll send the other PRs tomorrow.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Sep 7, 2019

Forgot to mention: looks good to me otherwise :)

@GuillaumeGomez GuillaumeGomez changed the title Better subclass feature handling Remove subclass feature Sep 7, 2019
@GuillaumeGomez GuillaumeGomez merged commit c343a1a into gtk-rs:master Sep 8, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:subclass branch Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.