Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully qualify inner macros for exported macros... #522

Merged
merged 1 commit into from Sep 7, 2019

Conversation

@fengalin
Copy link
Contributor

fengalin commented Sep 7, 2019

... otherwise they can't be resolved in dependent crates compiled
for edition 2018.

... otherwise they can't be resolved in dependent crates compiled
for edition 2018.
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Sep 7, 2019

Thanks, will merge once the CI is green :)

@fengalin

This comment has been minimized.

Copy link
Contributor Author

fengalin commented Sep 7, 2019

Thanks @sdroege! :)

@fengalin

This comment has been minimized.

Copy link
Contributor Author

fengalin commented Sep 7, 2019

All green! :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Sep 7, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 65d947e into gtk-rs:master Sep 7, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fengalin fengalin deleted the fengalin:inner_macro_export_macro branch Sep 7, 2019
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Sep 17, 2019

@GuillaumeGomez Can we get a bugfix release with this? :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Sep 19, 2019

@sdroege Ping me when I'm back. :)

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Sep 23, 2019

@sdroege Ping me when I'm back. :)

Ping :) Why did you read github notifications in your holidays? :P

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Sep 23, 2019

I detect moquery. :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.