Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Value::transform() #525

Merged
merged 3 commits into from Oct 1, 2019
Merged

Implement Value::transform() #525

merged 3 commits into from Oct 1, 2019

Conversation

@sdroege
Copy link
Member

sdroege commented Oct 1, 2019

And some minor fixes.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Oct 1, 2019

@sdroege Thanks

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Oct 1, 2019

Hrm

(process:7505): GLib-CRITICAL **: source_remove_from_context: assertion 'source_list != NULL' failed

thread '<unnamed>' panicked at 'Receiver without channel', src/libcore/option.rs:1190:5

test main_context_channel::tests::test_sync_channel ... FAILED

Unrelated to this change but should be investigated. Putting that on my list and merging.

@sdroege sdroege merged commit 2ad3ad8 into gtk-rs:master Oct 1, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Oct 2, 2019

reproduced here after running the tests in a loop for about 2 hours... ugly :)

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Oct 2, 2019

This is https://gitlab.gnome.org/GNOME/glib/merge_requests/675#note_589306 . Needs new API in GLib for fixing it reliable, which I'm going to work on in the next days but of course means that we won't have this working reliable until GLib 2.64 at least.

Nothing we can do about that here.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Oct 2, 2019

@sdroege Thanks for look at this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.