Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clone macro #527

Open
wants to merge 14 commits into
base: master
from

Conversation

@antoyo
Copy link
Member

antoyo commented Oct 22, 2019

No description provided.

examples/clone.rs Outdated Show resolved Hide resolved
examples/clone.rs Outdated Show resolved Hide resolved
examples/clone.rs Outdated Show resolved Hide resolved
examples/clone.rs Outdated Show resolved Hide resolved
src/clone.rs Outdated Show resolved Hide resolved
tests/clone_panic.rs Outdated Show resolved Hide resolved
tests/clone_panic.rs Outdated Show resolved Hide resolved
src/clone.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@antoyo

This comment has been minimized.

Copy link
Member Author

antoyo commented Oct 22, 2019

@sdroege @EPashkin @GuillaumeGomez I think this is ready for another round of review.

tests/clone.rs Show resolved Hide resolved
src/clone.rs Outdated Show resolved Hide resolved
src/clone.rs Show resolved Hide resolved
src/clone.rs Outdated Show resolved Hide resolved
src/clone.rs Outdated Show resolved Hide resolved
@sdroege sdroege referenced this pull request Oct 22, 2019
32 of 37 tasks complete
@antoyo

This comment has been minimized.

Copy link
Member Author

antoyo commented Oct 23, 2019

Tests fail because I use ? in macros which is not supported in edition 2015.

@antoyo

This comment has been minimized.

Copy link
Member Author

antoyo commented Oct 23, 2019

So, there's a problem when implementing the trait in the other crates:
only traits defined in the current crate can be implemented for arbitrary types.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Oct 23, 2019

So, there's a problem when implementing the trait in the other crates:
only traits defined in the current crate can be implemented for arbitrary types.

You only have to implement it on the final type, not on all types in the class hierarchy. Otherwise you'd implement it multiple times for the same type anyway.

src/object.rs Show resolved Hide resolved
src/object.rs Outdated Show resolved Hide resolved
src/clone.rs Outdated Show resolved Hide resolved
src/clone.rs Show resolved Hide resolved
src/clone.rs Show resolved Hide resolved
src/clone.rs Show resolved Hide resolved
src/clone.rs Show resolved Hide resolved
src/clone.rs Outdated Show resolved Hide resolved
src/clone.rs Show resolved Hide resolved
src/clone.rs Show resolved Hide resolved
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Nov 11, 2019

@antoyo You're going to work on the remaining parts?

@antoyo

This comment has been minimized.

Copy link
Member Author

antoyo commented Nov 11, 2019

@sdroege: I won't have time soon.

@sdroege sdroege force-pushed the antoyo:feature/clone-macro branch from ff3a013 to 90eb5ec Nov 12, 2019
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Nov 12, 2019

Should be good to go now

src/object.rs Outdated Show resolved Hide resolved
@sdroege sdroege referenced this pull request Nov 12, 2019
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Nov 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.