Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to futures 0.3 #531

Merged
merged 2 commits into from Nov 11, 2019
Merged

Update to futures 0.3 #531

merged 2 commits into from Nov 11, 2019

Conversation

@sdroege
Copy link
Member

sdroege commented Nov 11, 2019

And require Rust 1.39.

We can't use async/await in the tests/etc yet because that requires
switching to the 2018 edition, and that is blocked by
gtk-rs/gir#746

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Nov 11, 2019

@sdroege Thanks.
Maybe better leave empty "futures" trait until we process all other crates?
https://travis-ci.org/gtk-rs/glib/jobs/610219157#L670

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Nov 11, 2019

Maybe better leave empty "futures" trait until we process all other crates?

feature you mean? That would mean that we have to update everything twice :)

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Nov 11, 2019

@GuillaumeGomez Btw, we'll have to regen everything for this. gir PR coming soon

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Nov 11, 2019

Looks good to me! Waiting for CI.

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Nov 11, 2019

Looks good to me! Waiting for CI.

CI will fail until we updated all the things :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Nov 11, 2019

Ah.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Nov 11, 2019

@sdroege you seems forgot to remove FEATURES=futures from travis

sdroege added 2 commits Nov 11, 2019
And require Rust 1.39.

We can't use async/await in the tests/etc yet because that requires
switching to the 2018 edition, and that is blocked by
gtk-rs/gir#746
@sdroege sdroege force-pushed the sdroege:futures-stable branch from 730baec to 004c476 Nov 11, 2019
Copy link
Member

GuillaumeGomez left a comment

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit cbb8cf6 into gtk-rs:master Nov 11, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.