Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't leak missing Safety doc clippy warnings (#538) #539

Merged
merged 1 commit into from Nov 18, 2019

Conversation

@fengalin
Copy link
Contributor

fengalin commented Nov 17, 2019

With rustc 1.40.0, clippy checks that the unsafe functions come with
a Safety section. When running clippy on a downstream crate, the
macros such as glib_wrapper! leak the clippy warnings for the unsafe
functions.

Silence the warnings for now.

Fixes #538

With rustc 1.40.0, clippy checks that the `unsafe` functions come with
a `Safety` section. When running clippy on a downstream crate, the
macros such as `glib_wrapper!` leak the clippy warnings for the unsafe
functions.

Silence the warnings for now.
Copy link
Member

GuillaumeGomez left a comment

👍

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Nov 18, 2019

All the failures are caused by a GLib bug, which would be fixable on our side once https://gitlab.gnome.org/GNOME/glib/merge_requests/1175 is merged in GLib. Unlucking timing that so many of them failed in one build.

@sdroege sdroege merged commit c7c8d80 into gtk-rs:master Nov 18, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@fengalin fengalin deleted the fengalin:clippy-safety-section branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.