Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyFile::get_string() can return a string in error case that still ha… #544

Merged
merged 1 commit into from Nov 24, 2019

Conversation

@sdroege
Copy link
Member

sdroege commented Nov 24, 2019

…s to be freed

If it's an invalid UTF-8 string for example we still get it returned but
should simply free it. We can't return it as a String in any way.

Fixes #543

@sdroege sdroege mentioned this pull request Nov 24, 2019
40 of 43 tasks complete
…s to be freed

If it's an invalid UTF-8 string for example we still get it returned but
should simply free it. We can't return it as a String in any way.

Fixes #543
@sdroege sdroege force-pushed the sdroege:keyfile-get-string-leak branch from f330c02 to 22c0eae Nov 24, 2019
Copy link
Member

GuillaumeGomez left a comment

👍

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Nov 24, 2019

@sdroege Thanks, 👍

@sdroege sdroege merged commit faff657 into gtk-rs:master Nov 24, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.