Move gio::compile_resources to its own crate
#670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I need to update the CI workflows too? Not sure what I need to do exactly though |
|
This will either have to be moved to a separate crate or be removed completely, but keeping it inside the gio crate does not make much sense. |
|
@Hofer-Julian mentioned that the book is using this before introducing meson, so it shouldn't go away at least |
sdroege
reviewed
May 6, 2022
sdroege
reviewed
May 6, 2022
RealKC
force-pushed
the
fix574
branch
3 times, most recently
from
1fef9e9
to
db556bc
Compare
RealKC
force-pushed
the
fix574
branch
3 times, most recently
from
28fa242
to
57424fb
Compare
sdroege
approved these changes
May 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #574
Some things to consider:
gio-build-helpers,glib-build-helpersor something else entirely? This is (to me) made confusing by the fact that the executable is namedglib-compile-resourcesbut the resources machinery lives in Gio0.1.0or be in sync with the other crates? I don't think this would need version bumps at the same time as the other crates do, so I imagine it would end up desyncing sooner than later anywayNOTE: If this PR is alright, I'll send PRs to gtk4-rs and gtk3-rs to move the examples to this crate