Backport param spec builders #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commit of the following: commit b1f3ce8 Merge: 8873941 a3a291a Author: ranfdev <ranfdev@gmail.com> Date: Sun Feb 20 15:23:16 2022 +0100 merge upstream commit 8873941 Author: ranfdev <ranfdev@gmail.com> Date: Sun Feb 20 14:21:28 2022 +0100 add #[must_use] on the entire builder type commit a2bb5fb Author: ranfdev <ranfdev@gmail.com> Date: Sun Feb 20 14:21:00 2022 +0100 make ParamSpec*Builder new fn private, add missing builder method commit 5cf1929 Author: ranfdev <ranfdev@gmail.com> Date: Sat Feb 19 14:13:03 2022 +0100 improve flags comments for ParamSpec*Builder commit 5bf22b2 Author: ranfdev <ranfdev@gmail.com> Date: Sat Feb 19 12:28:03 2022 +0100 clearer missing parameter in ParamSpec*Builder commit 3d28cdb Author: ranfdev <ranfdev@gmail.com> Date: Sat Feb 19 12:20:18 2022 +0100 add required param in ParamSpecOverriddenBuilder commit 7e5a6fc Author: ranfdev <ranfdev@gmail.com> Date: Fri Feb 18 17:11:48 2022 +0100 add missing must_use commit b7a6fc6 Author: ranfdev <ranfdev@gmail.com> Date: Fri Feb 18 17:07:12 2022 +0100 Add required arguments on `ParamSpec` builders commit f677656 Author: ranfdev <ranfdev@gmail.com> Date: Fri Feb 18 10:03:47 2022 +0100 refactor, correctly handle `flags` in `ParamSpec*Builder` commit bbba561 Author: ranfdev <ranfdev@gmail.com> Date: Thu Feb 17 18:44:50 2022 +0100 Add missing ParamSpec builders, add define_builder_numeric commit 6be1563 Author: ranfdev <ranfdev@gmail.com> Date: Wed Feb 16 19:03:11 2022 +0100 add must use on methods returning Self commit 6cc4771 Author: ranfdev <ranfdev@gmail.com> Date: Wed Feb 16 18:24:59 2022 +0100 set builder is_a_type value to crate::Type::UNIT commit 33da4d4 Author: ranfdev <ranfdev@gmail.com> Date: Wed Feb 16 17:02:39 2022 +0100 improve test commit 427ad4b Author: ranfdev <ranfdev@gmail.com> Date: Wed Feb 16 17:01:19 2022 +0100 remove default value for required ParamSpecBuilder values commit c3792b0 Author: ranfdev <ranfdev@gmail.com> Date: Tue Feb 1 23:20:35 2022 +0100 define a corresponding `Builder` for each `ParamSpec`
sdroege
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting it here for reference as per discussion on the chat. Feel free to close it. Apart from this I did not find any other patch on mainline that applies cleanly to 0.15 and that does not break API.
This patchset applies cleanly to the stable branch and it is not an API break, only addition... on the other hand we do not have any evidence that the proposed API saw much testing.