Skip to content

pango: Backport Language changes #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 5, 2022
Merged

pango: Backport Language changes #846

merged 5 commits into from
Dec 5, 2022

Conversation

bilelmoussaoui
Copy link
Member

No description provided.

bilelmoussaoui and others added 2 commits December 4, 2022 21:20
@bilelmoussaoui
pango: Auto generate Language
f4c9889
@sdroege @bilelmoussaoui
pango: Make pango::Language::from_string() infallible
c40aa68 
It only ever returns `NULL` if passing `NULL`, which makes not much sense.
@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/backport-language branch from 28aa338 to e6706ba Compare December 4, 2022 20:39
bilelmoussaoui
bilelmoussaoui commented Dec 4, 2022
View reviewed changes
sdroege
sdroege reviewed Dec 5, 2022
View reviewed changes
@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/backport-language branch from e6706ba to de6c626 Compare December 5, 2022 08:33
@sdroege
Copy link
Member

sdroege commented Dec 5, 2022

Seems OK to backport otherwise

bilelmoussaoui and others added 3 commits December 5, 2022 10:02
@bilelmoussaoui
pango: Manually implement Language::to_string & Language::default
b1a4f62 
To avoid an API break for 0.16
@ranfdev @bilelmoussaoui
Add CastNone trait (#843)
78d3651 
* Add CastNone trait

Closes #842

* Add CastNone to prelude, add dynamic_cast

* Add example for CastNone

* Describe type using turbofish op
@bilelmoussaoui
Bump release to 0.16.5
edf607e
@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/backport-language branch from de6c626 to edf607e Compare December 5, 2022 09:03
@sdroege sdroege merged commit 81ac6fc into 0.16 Dec 5, 2022
@sdroege sdroege deleted the bilelmoussaoui/backport-language branch December 5, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdroege sdroege sdroege approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bilelmoussaoui @sdroege @ranfdev