Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates #20

Merged
merged 4 commits into from Feb 18, 2019

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Feb 17, 2019

Fixes #19.

cc @EPashkin @sdroege

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:updates branch from 293083b to 5b77478 Feb 17, 2019

Cargo.toml Outdated
@@ -21,7 +21,7 @@ gdk = { git = "https://github.com/gtk-rs/gdk" }
gtk = { git = "https://github.com/gtk-rs/gtk" }

[features]
default = ["gtk/v3_10"]
default = ["gtk/v3_16"]

This comment has been minimized.

@sdroege

sdroege Feb 18, 2019

Member

Why do you suddenly need v3_16 here?

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Feb 18, 2019

Author Member

I just replaced. But I guess it's pretty useless in fact... I'll remove it.

This comment has been minimized.

@sdroege

sdroege Feb 18, 2019

Member

You should only add such things if you're actually requiring new API from 3.16 :)

This comment has been minimized.

@sdroege

sdroege Feb 18, 2019

Member

Good to go after that change

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:updates branch from 5b77478 to efb866f Feb 18, 2019

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:updates branch from 775d83f to 039b355 Feb 18, 2019

.travis.yml Outdated
# - if [ "$TRAVIS_RUST_VERSION" == "nightly" ]; then
# rustup component add clippy;
# cargo clippy --release;
# fi

This comment has been minimized.

@sdroege

sdroege Feb 18, 2019

Member

What's wrong with them?

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Feb 18, 2019

Author Member

Look at travis logs, you'll see what dark magic is. :)

This comment has been minimized.

@sdroege

sdroege Feb 18, 2019

Member

It's installed by default now or not? There's no separate component for it.

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Feb 18, 2019

Author Member

I couldn't make it work and at this point, it's just annoying.

This comment has been minimized.

@sdroege

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Feb 18, 2019

Author Member

Ah indeed. I remove the last commit and then I merge.

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:updates branch from 0c54443 to 039b355 Feb 18, 2019

@GuillaumeGomez GuillaumeGomez merged commit f7f119b into gtk-rs:master Feb 18, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:updates branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.