Trampoline transform #400

Merged
merged 4 commits into from Jan 6, 2017

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Nov 6, 2016

Part of gtk-rs/gir#264
Applying trampoline transformation in gtk-rs/gir#293

WIP

Borrow:
TreeView: added signal move-cursor
...
TreePath:
CellRendererCombo::changed: +borrow
CellArea: +borrow, add-editable also has Rectangle

@EPashkin EPashkin changed the title from Trampoline transform borrow to Trampoline transform Nov 6, 2016

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 6, 2016

Member

@GuillaumeGomez, @gkoz take look at regen samples.

Member

EPashkin commented Nov 6, 2016

@GuillaumeGomez, @gkoz take look at regen samples.

}
-impl<O: IsA<CellArea>> CellAreaExt for O {
+impl<O: IsA<CellArea> + IsA<Object>> CellAreaExt for O {

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Nov 6, 2016

Member

If IsA<CellArea> is "true", then shouldn't IsA<Object> be "true" as well?

@GuillaumeGomez

GuillaumeGomez Nov 6, 2016

Member

If IsA<CellArea> is "true", then shouldn't IsA<Object> be "true" as well?

This comment has been minimized.

@EPashkin

EPashkin Nov 6, 2016

Member

Currently - not, so we adding it to all traits with signal.
You seen this in #394

@EPashkin

EPashkin Nov 6, 2016

Member

Currently - not, so we adding it to all traits with signal.
You seen this in #394

src/auto/cell_renderer_accel.rs
@@ -1,9 +1,12 @@
-// This file was generated by gir (4d68d19) from gir-files (11e0e6d)
+// This file was generated by gir (bc9cb02) from gir-files (???)

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Nov 6, 2016

Member

Why has it become '???'?

@GuillaumeGomez

GuillaumeGomez Nov 6, 2016

Member

Why has it become '???'?

This comment has been minimized.

@EPashkin

EPashkin Nov 6, 2016

Member

Its rust's git bug with submodule objects/info/alternates in msys.
I make it normal when ready to merge.

@EPashkin

EPashkin Nov 6, 2016

Member

Its rust's git bug with submodule objects/info/alternates in msys.
I make it normal when ready to merge.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 6, 2016

Member

So now we can generate trampolines as well? 😂

Member

GuillaumeGomez commented Nov 6, 2016

So now we can generate trampolines as well? 😂

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 6, 2016

Member

Well, I don't have much to say on this PR. Good job!

Member

GuillaumeGomez commented Nov 6, 2016

Well, I don't have much to say on this PR. Good job!

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 6, 2016

Member

In signal.rs only last Editable and SpinButton with too specific code

Member

EPashkin commented Nov 6, 2016

In signal.rs only last Editable and SpinButton with too specific code

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 13, 2016

Member

It's been around for a week and like it's ok for me. Still no news from @gkoz. If it's ok for you @EPashkin, I'll merge this (waiting for confirmation).

Member

GuillaumeGomez commented Nov 13, 2016

It's been around for a week and like it's ok for me. Still no news from @gkoz. If it's ok for you @EPashkin, I'll merge this (waiting for confirmation).

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 13, 2016

Member

No, this is not ready for merge.
Stalled by gtk-rs/gir#293 (its better not be merged without @gkoz review), and 293 based on gtk-rs/gir#292 that IMHO you can merge.

Member

EPashkin commented Nov 13, 2016

No, this is not ready for merge.
Stalled by gtk-rs/gir#293 (its better not be merged without @gkoz review), and 293 based on gtk-rs/gir#292 that IMHO you can merge.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 13, 2016

Member

Ok, I merge the mergeable one and wait for the other.

Member

GuillaumeGomez commented Nov 13, 2016

Ok, I merge the mergeable one and wait for the other.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Dec 20, 2016

Member

Rebased, but still not ready

Member

EPashkin commented Dec 20, 2016

Rebased, but still not ready

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jan 6, 2017

Member

Ready for merge

Member

EPashkin commented Jan 6, 2017

Ready for merge

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jan 6, 2017

Member

Waiting for appveyor and then I merge.

Thanks a lot for your work! :)

Member

GuillaumeGomez commented Jan 6, 2017

Waiting for appveyor and then I merge.

Thanks a lot for your work! :)

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jan 6, 2017

Member

Restarted appveyor (error due network failure)

Member

EPashkin commented Jan 6, 2017

Restarted appveyor (error due network failure)

@GuillaumeGomez GuillaumeGomez merged commit df64887 into gtk-rs:master Jan 6, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:trampoline_transform_borrow branch Jan 6, 2017

@EPashkin EPashkin referenced this pull request Mar 4, 2017

Closed

Make a new release #451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment