New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree sortable ignore get sort column #421

Merged
merged 2 commits into from Jan 2, 2017

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Jan 2, 2017

@GuillaumeGomez, I just don't remember why get was not ignored.
May be it was some reason (backward compatibility etc.)?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jan 2, 2017

Member

I don't remember at all why it was bound in the first place. Whatever, once tests passed, I merge.

Member

GuillaumeGomez commented Jan 2, 2017

I don't remember at all why it was bound in the first place. Whatever, once tests passed, I merge.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jan 2, 2017

Member

Enum SortColumn was added to manual part to separate -1 and other column numbers

Member

EPashkin commented Jan 2, 2017

Enum SortColumn was added to manual part to separate -1 and other column numbers

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin
Member

EPashkin commented Jan 2, 2017

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jan 2, 2017

Member

Oh I see. Makes sense.

Member

GuillaumeGomez commented Jan 2, 2017

Oh I see. Makes sense.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jan 2, 2017

Member

Thanks!

Member

GuillaumeGomez commented Jan 2, 2017

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit dbde47a into gtk-rs:master Jan 2, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:tree_sortable_ignore_get_sort_column_id branch Jan 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment