New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore duplicate parent methods #425

Merged
merged 2 commits into from Jan 18, 2017

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Jan 17, 2017

Part of gtk-rs/gir#139
Applying gtk-rs/gir#305.
Don't builds until gtk-rs/examples#106 merged.

Not ready for merge as need "Update gir submodule"

Show outdated Hide outdated src/auto/file_chooser_button.rs
@@ -1,4 +1,4 @@
// This file was generated by gir (e48471c) from gir-files (71d73f0)
// This file was generated by gir (5be24b7+) from gir-files (71d73f0)

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Jan 17, 2017

Member

The hash is different here and ends with a '+'. Is this normal?

@GuillaumeGomez

GuillaumeGomez Jan 17, 2017

Member

The hash is different here and ends with a '+'. Is this normal?

This comment has been minimized.

@EPashkin

EPashkin Jan 17, 2017

Member

Yes, it just sample.

@EPashkin

EPashkin Jan 17, 2017

Member

Yes, it just sample.

EPashkin added some commits Jan 17, 2017

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jan 17, 2017

Member

Ready for merge

Member

EPashkin commented Jan 17, 2017

Ready for merge

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jan 17, 2017

Member

Awesome! Thanks! (Waiting for appveyor before merging.)

Member

GuillaumeGomez commented Jan 17, 2017

Awesome! Thanks! (Waiting for appveyor before merging.)

@GuillaumeGomez GuillaumeGomez merged commit dae575d into gtk-rs:master Jan 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:ignore_duplicate_parent_methods branch Jan 18, 2017

@EPashkin EPashkin referenced this pull request Mar 4, 2017

Closed

Make a new release #451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment