New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gtk::PopoverConstraint and related Popover methods. #427

Merged
merged 2 commits into from Jan 19, 2017

Conversation

Projects
None yet
3 participants
@Susurrus
Contributor

Susurrus commented Jan 18, 2017

Related to #426.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jan 18, 2017

Member

Strange it wasn't generated before... Thanks!

@EPashkin: good for you as well?

Member

GuillaumeGomez commented Jan 18, 2017

Strange it wasn't generated before... Thanks!

@EPashkin: good for you as well?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jan 18, 2017

Member

@Susurrus, please, separate PR to 2 commit. First update gir and then "Regen"

Member

EPashkin commented Jan 18, 2017

@Susurrus, please, separate PR to 2 commit. First update gir and then "Regen"

@Susurrus

This comment has been minimized.

Show comment
Hide comment
@Susurrus

Susurrus Jan 18, 2017

Contributor

Done.

Contributor

Susurrus commented Jan 18, 2017

Done.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jan 18, 2017

Member

Thanks. @GuillaumeGomez, 👍 after builds

Member

EPashkin commented Jan 18, 2017

Thanks. @GuillaumeGomez, 👍 after builds

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jan 18, 2017

Member

Yes sir!

Member

GuillaumeGomez commented Jan 18, 2017

Yes sir!

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jan 18, 2017

Member

@GuillaumeGomez, it wasn't generated due it was added in 3.20 and on that update was too many changes. We simply missed new commented functions (69810fc)

Member

EPashkin commented Jan 18, 2017

@GuillaumeGomez, it wasn't generated due it was added in 3.20 and on that update was too many changes. We simply missed new commented functions (69810fc)

@Susurrus

This comment has been minimized.

Show comment
Hide comment
@Susurrus

Susurrus Jan 18, 2017

Contributor

It passed, anyone wanna merge?

Contributor

Susurrus commented Jan 18, 2017

It passed, anyone wanna merge?

@GuillaumeGomez GuillaumeGomez merged commit 021a197 into gtk-rs:master Jan 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin referenced this pull request Mar 4, 2017

Closed

Make a new release #451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment