New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all properties #428

Merged
merged 3 commits into from Jan 27, 2017

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Jan 21, 2017

Result solving of gtk-rs/gir#304

Currently just sample, as all properties added without check for duplicates.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jan 21, 2017

Member

This is so awesome! Did you remove the methods that were implemented by hand too? It'd be fun to have the same method implemented in an *Ext trait and inside the struct directly. ;)

Member

GuillaumeGomez commented Jan 21, 2017

This is so awesome! Did you remove the methods that were implemented by hand too? It'd be fun to have the same method implemented in an *Ext trait and inside the struct directly. ;)

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jan 21, 2017

Member

Thanks for reminder. I will do it after done with generated duplicate cleanup.

Member

EPashkin commented Jan 21, 2017

Thanks for reminder. I will do it after done with generated duplicate cleanup.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jan 24, 2017

Member

🎉 First build-able version.

Member

EPashkin commented Jan 24, 2017

🎉 First build-able version.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez
Member

GuillaumeGomez commented Jan 24, 2017

🎉

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jan 25, 2017

Member

Almost all properties generated.
As last 15 properties with unsupported types (gdk::RGBA, &[&str], GLib.Variant, pango::AttrList, ..),
so this code will be not changed (may be with exception of removing some properties that already presents in parent).
I still need do parent check, some refactoring in gir, and find & remove manual properties here (it all may take some time).
gio also affected by properties generation, I add PR later.

Member

EPashkin commented Jan 25, 2017

Almost all properties generated.
As last 15 properties with unsupported types (gdk::RGBA, &[&str], GLib.Variant, pango::AttrList, ..),
so this code will be not changed (may be with exception of removing some properties that already presents in parent).
I still need do parent check, some refactoring in gir, and find & remove manual properties here (it all may take some time).
gio also affected by properties generation, I add PR later.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jan 26, 2017

Member

@GuillaumeGomez, I checked manual parts and don't found any conflicting with properties method.
Also parent properties check shows none conflict, so I removed it from gir code.

Member

EPashkin commented Jan 26, 2017

@GuillaumeGomez, I checked manual parts and don't found any conflicting with properties method.
Also parent properties check shows none conflict, so I removed it from gir code.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jan 26, 2017

Member

Perfect, thanks a lot! Anything else you want to do on this PR or can I merge it?

Member

GuillaumeGomez commented Jan 26, 2017

Perfect, thanks a lot! Anything else you want to do on this PR or can I merge it?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jan 26, 2017

Member

It not ready for merge, as no gir update

Member

EPashkin commented Jan 26, 2017

It not ready for merge, as no gir update

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jan 27, 2017

Member

Final version, ready for merge

Member

EPashkin commented Jan 27, 2017

Final version, ready for merge

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jan 27, 2017

Member

Thanks for your amazing work!

Member

GuillaumeGomez commented Jan 27, 2017

Thanks for your amazing work!

@GuillaumeGomez GuillaumeGomez merged commit 7466293 into gtk-rs:master Jan 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:generate_properties branch Jan 27, 2017

@EPashkin EPashkin referenced this pull request Mar 4, 2017

Closed

Make a new release #451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment